search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Introduces a re-architecture and popup attachments. #164

Closed esreli closed 5 years ago

esreli commented 5 years ago

Adding @ChrisFrenchPDX to absorb the review of comments and doc related to this PR. @philium @nixta feel free to contribute to this aspect of the conversation or feel free to focus on the code only, if you so choose.

esreli commented 5 years ago

@philium i've worked through most of your comments, would you have another look?

esreli commented 5 years ago

@mikewilburn as this PR is coming to a close, can I ask you to perform a series of tests to confirm the app works as spec'd and according to the test design doc?

esreli commented 5 years ago

@philium i've finished responding to your review. Would you review the new changes?

esreli commented 5 years ago

@ChrisFrenchPDX as the PR is coming to an end, might you be able to give a second pass at the comments?

esreli commented 5 years ago

@philium i've made all changes from your latest review. Would you please have another look?

esreli commented 5 years ago

Thank you, all. I've finished combing through all of your reviews. I will be merging this branch as-is by EOD, unless I hear anything otherwise.

Review now or forever hold your peace ✌