v1.1 : attachments & accessibility

esreli commented 5 years ago

Targeted goal to merge alongside U5.

All code in v.next has been approved. This PR serves as the last opportunity to catch issues as well as to report bugs found in testing.

I've added a number of viewers and am accepting contributions from anyone.

@nixta if you might (have the time to) examine the code with a critical lens on it's usage of the Runtime SDK
@mikewilburn if you might examine the app in the context of testing
@ChrisFrenchPDX if you might examine the code and repository resources for clarity of comments and general messaging

mikewilburn commented 5 years ago

@esreli 👍 just got the latest v.next branch pulled down onto the iPhone X, so I'll be testing and further fleshing out the test design with these latest commits.

esreli commented 5 years ago

@nixta i've addressed the first bit of your review.

esreli commented 5 years ago

@nixta i've implemented changes for review comments that I was able to understand. There are still a few comments that remain open and require clarification.

Esri / data-collection-ios

v1.1 : attachments & accessibility #167