search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

sets minimum font scale for attachment names #170

Closed esreli closed 5 years ago

esreli commented 5 years ago

Before: (note the ellipsis) Screen Shot 2019-03-20 at 1 43 38 PM

After: (note the reduced font size) Screen Shot 2019-03-20 at 1 42 55 PM

mikewilburn commented 5 years ago

I think this is an excellent solution. Here's another before/after look at the effect of this PR:

image image image

philium commented 5 years ago

As @mikewilburn's screenshots show, it is still possible for names to be truncated. That's fine, but you might consider truncating middle rather than tail. If you want the full name to be visible no matter what, you could let the name label grow to multiple lines.

mikewilburn commented 5 years ago

I still think this is a reasonable enough solution that will accommodate for a vast majority of the cases out there.

I also noticed that before the image/file itself will load, the view will display the filename instead:

image