search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Adds entitlements build phase run script #185

Closed esreli closed 5 years ago

nixta commented 5 years ago

Should this be patched onto the end of the existing script, or added as a separate script? I suspect the latter option would be preferred.

esreli commented 5 years ago

I suspect the latter option would be preferred.

I don't mind creating a separate script. I'm curious though why you think this is preferred?

nixta commented 5 years ago

They do different things. I also don't know if they should be doing them at the same position in the build phase steps (but probably it doesn't matter).

But mostly, having it as a separate phase step relates it more cleanly to the SDK guide instructions.

esreli commented 5 years ago

@nixta i've incorporated your suggestion. Have another look?