Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Mhd/layer contents integration #230

Closed mhdostal closed 4 years ago

mhdostal commented 4 years ago

Included in this PR:

Extras alert: Extras

Layers: Layers

Bookmarks: Bookmarks

mhdostal commented 4 years ago

@philium - I'm done making the suggested changes and addressing comments, so please give it another look.

The outstanding issues:

Thanks again for your review, it really helps make the code better.

mhdostal commented 4 years ago

@esreli, @philium I've addressed all the comments. Unless I missed something, the only outstanding item item is:

~- potentially show a title and "Done" button when displaying either the TOC or Bookmarks VC.~

mhdostal commented 4 years ago

@esreli I added the code to adjust the state of the extras button. Can you take look and make sure it's OK? One thing I wasn't sure about is the selectedFeature enum takes a Bool; I've added that item in the check twice:

mapViewMode == .selectedFeature(featureLoaded: false) ||
mapViewMode == .selectedFeature(featureLoaded: true) ||
mhdostal commented 4 years ago

@philium - can you give this a final(?) look?

mhdostal commented 4 years ago

@philium, @rolson I made the changes requested, please have another look.

mhdostal commented 4 years ago

@philium - Awesome, thank you for all the help!

philium commented 4 years ago

@mhdostal You're welcome! I'm happy to help.

mhdostal commented 4 years ago

@rolson Thanks!