Closed mhdostal closed 4 years ago
Toolkit Warnings
There are 22 warnings associated with the Toolkit. Would it be possible to resolve these warnings? I'm afraid it's not good for our customers and not a good look for Data Collection.
I'm using toolkit commit
b57fc2ee2372a2f32aea7e9fa9948dc6eec8a763
@esreli What version of Xcode/iOS are you building for? I don't see any warnings on my end.
https://github.com/Esri/data-collection-ios/pull/232#issuecomment-632148288 @mhdostal
Xcode 11.4.1 iOS 13.3 Simulated on iPhone 11
The 22 warnings:
20 warnings are identical to this one for different TimeSlider
properties:
/Users/eli9422/Documents/runtime/example/data-collection/ios/data-collection-ios/arcgis-runtime-toolkit-ios/Toolkit/ArcGISToolkit/TimeSlider.swift:2216:5: Lower ACL than parent Violation: Ensure definitions have a lower access control level than their enclosing parent (lower_acl_than_parent)
2 warnings are identical to this one for JobManager
:
/Users/eli9422/Documents/runtime/example/data-collection/ios/data-collection-ios/arcgis-runtime-toolkit-ios/Toolkit/ArcGISToolkit/JobManager.swift:202:12: Attributes Violation: Attributes should be on their own lines in functions and types, but on the same line as variables and imports. (attributes)
Because Runtime introduced support for Metal at 100.8, I was unable to test the application using an iOS 12 simulator. Have you verified the app works as expected on a device running iOS 12?
Not on a device; all my devices are iOS 13.
@esreli - The Toolkit warnings you're encountering may be caused by an outdated SwiftLint. Update and see if that helps.
iOS 13 WorkMode contextualized navigation bar issue
I implemented your changes.
The testing report for iOS 12 found no iOS 12 specific issues.
Everything for the v1.2 release: