search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

App configuration: brevity #235

Closed esreli closed 4 years ago

esreli commented 4 years ago

This PR accomplishes a number of tasks for improving the brevity and readability of static configuration tasks.

Swaps class AppConfiguration and AppFiles.OfflineDirectoryComponents for a series of static String and URL extensions. This technique allows for brevity through type inference. For example:

- try AGSArcGISRuntimeEnvironment.setLicenseKey(AppConfiguration.licenseKey)
+ try AGSArcGISRuntimeEnvironment.setLicenseKey(.licenseKey)
esreli commented 4 years ago

https://github.com/Esri/data-collection-ios/pull/235#discussion_r432541184

This is a good suggestion. I've made this change.

I've also made another change. I've decided to formalize the role of a OAuth type. I'm not committed to the idea but I do like what it might offer. Would you please re-review?