search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Moves single-use extensions from isolated file to caller file #259

Closed esreli closed 3 years ago

esreli commented 3 years ago

Note, no code change is performed in this PR. This change is progressively performed to clean up the project structure by moving existing single-use extensions from their isolated file to the caller file.

philium commented 3 years ago

For those that you can (like AGSMap), I would suggest making the extension private. As for the other extensions (like those that add conformance to a protocol), they can't be made private, which is a good argument for keeping them in separate source files. Since they are non-private, they could end up being used elsewhere at any time, making them non-single-use. Just a thought.

esreli commented 3 years ago

I would suggest making the extension private.

This is a good call.

esreli commented 3 years ago

@mhdostal @philium i'm marking this first batch as ready for review. Would you have a look and offer your feedback? Thank you in advance.

esreli commented 3 years ago

@mhdostal have you had a chance to review this PR? what do you think?