search

Esri / data-collection-ios

Mobile data collection app using the iOS Runtime SDK.
https://developers.arcgis.com/
Apache License 2.0
25 stars 26 forks source link

Enhanced support for pop-up date attribute editing #267

Closed esreli closed 3 years ago

esreli commented 3 years ago

This PR introduces enhanced support for pop-up date attribute editing.

  1. Introduces new table cell, PopupAttributeDatePickerCell, for use by devices running iOS 14. This cell leverages the new iOS 14 UIDatePicker, placing the UI element within the attribute cell rather than displaying a date picker in the keyboard area.
  2. Introduces support for time as well as date (iOS 13 & 14)

See related issues:

Screenshots

iOS 13 iOS 14 - in-line iOS 14 - expanded
Simulator Screen Shot - iPhone 11 Pro Max - 2020-11-25 at 14 03 20 Simulator Screen Shot - iPhone 11 Pro Max - 2020-11-25 at 14 16 24 Simulator Screen Shot - iPhone 11 Pro Max - 2020-11-25 at 14 16 27
Dark Mode Dynamic Text Size
Simulator Screen Shot - iPhone 11 Pro Max - 2020-11-25 at 14 00 50 Simulator Screen Shot - iPhone 11 Pro Max - 2020-11-25 at 14 01 05
iPad - in-line iPad - expanded
Simulator Screen Shot - iPad Pro (9 7-inch) - 2020-11-25 at 14 02 33 Simulator Screen Shot - iPad Pro (9 7-inch) - 2020-11-25 at 14 02 37
esreli commented 3 years ago

Thank you @mhdostal. I've addressed your review, would you have another look?

esreli commented 3 years ago

@mhdostal i've force pushed a rebase that resolves some merge conflicts. Merging.