Esri / developer-support

Proof of concept developer code and samples to help be successful with all ArcGIS developer products (Python, NET, JavaScript, Android…). The repository is designed to be an exchange for sharing coding conventions and wisdom to developers at all skill levels.
Apache License 2.0
268 stars 165 forks source link

Script that appends spatial data into feature class #253

Closed kgalliher closed 8 years ago

kgalliher commented 8 years ago

Simple insert cursor that pulls rows from a table containing a geometry column into a non-versioned feature class table.

MarieAshley commented 8 years ago

Hey @natas333x2

Nice script! Tested this out with SQL Server 2014 and ArcMap 10.4.1, it works! There are only a few documentation things I saw:

The Readme asks us to create InputTable2, but the script asks for InputTable.

The comments in the script itself are really helpful to get this going. This may not be necessary, but it may be helpful if some of those comments were ported over to the Readme. For example:

Also, adding a field in ArcGIS for Desktop creates a nvarchar(n) field and we can use a schema other than DBO (tested with SDE).

Let me know what you think, otherwise I think this is ready to merge!

kgalliher commented 8 years ago

I can definitely make those changes. Thanks for taking a look!

On Fri, Jul 29, 2016, 12:50 PM Marie notifications@github.com wrote:

Hey @natas333x2 https://github.com/natas333x2

Nice script! Tested this out with SQL Server 2014 and ArcMap 10.4.1, it works! There are only a few documentation things I saw:

The Readme asks us to create InputTable2, but the script asks for InputTable.

The comments in the script itself are really helpful to get this going. This may not be necessary, but it may be helpful if some of those comments were ported over to the Readme. For example:

  • We need to substitute the target table in the code with the first table we created in ArcGIS for Desktop.
  • Ensure SRIDs are homogenous between input table and target table.

Also, adding a field in ArcGIS for Desktop creates a nvarchar(n) field and we can use a schema other than DBO (tested with SDE).

Let me know what you think, otherwise I think this is ready to merge!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Esri/developer-support/pull/253#issuecomment-236276822, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8vKfP1u67R5VHOtrJoaAtcy0LvgLp4ks5qallwgaJpZM4JXrlP .