search

Esri / developer-support

Proof of concept developer code and samples to help be successful with all ArcGIS developer products (Python, NET, JavaScript, Android…). The repository is designed to be an exchange for sharing coding conventions and wisdom to developers at all skill levels.
Apache License 2.0
268 stars 165 forks source link

ArcSDESQLExecute and pyodbc examples #285

Closed kgalliher closed 7 years ago

kgalliher commented 7 years ago

ArcSDESQLExecute and pyodbc examples

MarieAshley commented 7 years ago

Nice! If you don't have someone in mind already, I'll test this.

kgalliher commented 7 years ago

@MarieAshley Please do! Let me know what you find.

MarieAshley commented 7 years ago

Tested, everything works!

jgravois commented 7 years ago

nice work guys!

there's no harm in the way you've already done it, but next time a PR like this would make a good candidate for commit squashing, either prior to merge or using GitHub's new handy tools mid-merge.

https://github.com/blog/2141-squash-your-commits http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request

MarieAshley commented 7 years ago

Thanks for the links @jgravois. Neat, squash and merge!