search

Esri / developer-support

Proof of concept developer code and samples to help be successful with all ArcGIS developer products (Python, NET, JavaScript, Android…). The repository is designed to be an exchange for sharing coding conventions and wisdom to developers at all skill levels.
Apache License 2.0
268 stars 165 forks source link

Add attachments to FeatureService using 4.x #286

Closed nhaney90 closed 7 years ago

nhaney90 commented 7 years ago

Version 4.x of the JavaScript API does not currently offer any tools to work with attachments. However using JavaScript and the REST API we can recreate the look and functionality of the 3.x Attachment Editor.

nohe427 commented 7 years ago

Whats up with the commits @jgravois

nhaney90 commented 7 years ago

Not sure what happened. I made the changes that @jgravois requested and then synced my changes. I think I may have updated from the wrong branch.

nohe427 commented 7 years ago

I think I fixed it

jgravois commented 7 years ago

the extraneous commits were the result of @nhaney90 syncing his own master branch with Esri/gh-pages upstream.

now that @nohe427 has updated the base branch in this PR to be Esri/gh-pages, the commits that are not present in Esri/master no longer appear in the diff.

jgravois commented 7 years ago

@nhaney90 how do you feel about using calcite icons?

nhaney90 commented 7 years ago

@jgravois changed images in popup to Calcite icons. Also updated the gif to reflect the changes.

jgravois commented 7 years ago

squashed and merged. nice work @nhaney90!