search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Distance And Direction: Radials for rings are not created at the correct length in ArcGIS Pro #181

Closed lfunkhouser closed 7 years ago

lfunkhouser commented 7 years ago

From @elinz on December 5, 2016 18:45

When I use the Rings function on the Distance And Direction addin the length of the radials created do not have the correct length. See screenshot below:

image

Expected Behavior

The length of the radials created should match the radius of the outer most ring.

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

Copied from original issue: Esri/military-tools-for-arcgis#67

lfunkhouser commented 7 years ago

From @elinz on December 5, 2016 18:58

We know that at least for 1.2 and 1.3 we can't create geodetic lines so the "Number of Radials" parameter should be hidden/disabled or removed.

lfunkhouser commented 7 years ago

From @kgonzago on December 5, 2016 20:48

@nfeuerstein @topowright Should we remove Radials from Distance and Direction Pro 1.2/1.3 entirely?

lfunkhouser commented 7 years ago

From @nfeuerstein on December 5, 2016 21:17

@kgonzago - Distance and Direction is dead in 1.2 all together. For 1.3, we should probably remove radials if there is no way to fix it. It seems to me that 1.3 doesn't support radials.

lfunkhouser commented 7 years ago

From @Dbarnes1 on December 5, 2016 21:22

@nfeuerstein would an alternative to removing radials in 1.3 be to include a known issue about radials not working properly in our documentation? This is what we are currently doing in regards to line creation in the add-in. See this PR: https://github.com/ArcGIS/arcgis-solutions-website/pull/4608/files

lfunkhouser commented 7 years ago

From @nfeuerstein on December 5, 2016 21:32

@Dbarnes1 yes, that is an alternative. The bottom line is that lines aren't supported, we can either document that geodesic lines aren't supported or we can remove the option. Which is more feasible?

Documenting it puts the onus on the user to understand its not supported, and removing it puts the onus on us.

lfunkhouser commented 7 years ago

From @Dbarnes1 on December 5, 2016 21:36

@nfeuerstein I think updating the documentation with a known issue for pro 1.3, and then removing the functionality for lines and radials in pro 1.4 would be the most suitable option considering the current technical limitations.

lfunkhouser commented 7 years ago

From @nfeuerstein on December 5, 2016 21:40

Sounds like a plan. Any issues with that @kgonzago?

lfunkhouser commented 7 years ago

From @kgonzago on December 9, 2016 13:44

I like that plan. This is similar to #68. Once issue persists when testing with Pro 1.4, the line and radials will be removed entirely.

lfunkhouser commented 7 years ago

From @elinz on December 9, 2016 16:11

@kgonzago I installed the latest build of Military Tools for ArcGIS that I believe was built on 1.3 SDK and the same issue exists.

elinz commented 7 years ago

@kgonzago Still an issue at Pro 1.4. See #180.

mfunk commented 7 years ago

@kgonzago @pHill5136 Just an FYI, none of the Distance and Direction lines are geodesic, this means the Line tab features as well as the radials on the Rings tab.

image

image

pHill5136 commented 7 years ago

@nfeuerstein @kgonzago I hid the radials label and text box on range rings and commented out the lines tab. pull request https://github.com/Esri/distance-direction-addin-dotnet/pull/193

mfunk commented 7 years ago

Lines tab is removed: image

And Radials option is removed from Rings image