Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Entering very large Radius/Diameter when creating a circle causes graphical glitch with multiple lines drawn across map (ArcMap) #198

Closed rjones0 closed 7 years ago

rjones0 commented 7 years ago

Procedure:

  1. Add a world background data source in ArcMap
  2. Display Circle tab on Distance and Direction addin UI panel
  3. Click Map Point tool
  4. Click on map to create a point
  5. Click in Radius/Diameter text box
  6. Enter a 1 and then keep adding zeros

Result: From 100000000000 upwards multiple intersecting lines are drawn across map (which presumably is not desired behaviour)

Result expected: the glitch is not seen. User is informed that value is beyond bounds.

rjones0 commented 7 years ago

glitch

rjones0 commented 7 years ago

This issue also occurs with:

Circle tab: Time field Rate field

Ellipse tab: Axis: Major

mfunk commented 7 years ago

Ok so this brings up the idea that there are critical limits for different units for these parameters. We'll need to research what each one should be for each relevant parameter on each tool. Essentially what is happening is that the graphic is wrapping around the globe and over itself many times... and looks like crap. We'll need to trap those numbers and display some kind of message about self-overlapping features.

rjones0 commented 7 years ago

I examined using get_IsSimpleEx to determine when the polygon becomes self-intersecting (as an indicator that the polygon should not be displayed) but the operation is slow to execute when the intersections are many.

Ref: http://desktop.arcgis.com/en/arcobjects/latest/net/ITopologicalOperator3_IsSimpleEx.htm

rjones0 commented 7 years ago

It would seem to me that the limit for Radius should be the value at which the polygon will encompass the entire earth, i.e. just slightly over 20000km. There are also dateline issues as described in #280.

rjones0 commented 7 years ago

PR: https://github.com/Esri/distance-direction-addin-dotnet/pull/318

rjones0 commented 7 years ago

Fix for:

Ellipse tab: Axis: Major

still outstanding

rjones0 commented 7 years ago

PR: https://github.com/Esri/distance-direction-addin-dotnet/pull/322

lfunkhouser commented 7 years ago

Reopened issue for MT PEs to verify

NatalieCampos commented 7 years ago

The errors that created this issue have been resolved. When adding a large value to either the radius or diameter of circles or the Major axis of Ellipse an invalid input error is thrown.

image