search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Creating a line from distance and bearing - angle warning - ArcMap #246

Closed joebayles closed 7 years ago

joebayles commented 7 years ago

When adding the angle, if the angle exceeds 360 degrees, it still renders a line. In it's defense, 2700 degrees really is 180 degrees, but I think it should at least show a warning.

dfoll commented 7 years ago

This is something that should be added to the validation based on the selection of mils or degrees. Good Catch

rjones0 commented 7 years ago

I have a fix for this locally, will make a pull request when possible.

rjones0 commented 7 years ago

PR: https://github.com/Esri/distance-direction-addin-dotnet/pull/305

lfunkhouser commented 7 years ago

Assigning to @joebayles who originally submitted the issue and the MT PEs to verify.

topowright-zz commented 7 years ago

This is still an issue. We should have the same interaction that happens in the Visibility Add in when an angle is put in that is higher than 360

image

This should be done when using degrees for one and for mils it would be 6400 mil. From my research that is that amount of mils in a circle. If I am wrong the tool should turn red when the number exceeds the equivalent of 360 degrees

topowright-zz commented 7 years ago

Saw that this covered ArcMap and I found the following error with the verification:

image

ArcGIS Pro does not conduct any validation. I think this issue should cover ArcMap and ArcGIS Pro.

@pHill5136 FYI; thought you would care based on the pull request that you merged.

lfunkhouser commented 7 years ago

Assigning Devs - @csmoore and @kgonzago and adding backlog label

csmoore commented 7 years ago

I wasn't exactly able to reproduce this issue, but I did notice some badness when distance=0 (as show in the screenshot), so added a check for that - can you retest in the next daily? Reassigning for re-test.

I also noticed several other issues with the feedback graphic while testing this recorded in new issue #364

ACueva commented 7 years ago

@csmoore I don't know, is this the output you were expecting? 2017-05-03_9-47-23

FYI I didn't enter the distance as 0. It defaulted back to zero after hitting enter from the angle input box.

NatalieCampos commented 7 years ago

verified. values between 340-360 work. values greater than 360 do not.

NatalieCampos commented 7 years ago

This issue still isnt fixed. The graphic still draws past 360. It actually draws the last valid angle that was dynamically drawn.

image

csmoore commented 7 years ago

I have a change for this that resets the the feedback angle to zero (its initial state) - hopefully this will work to clear up the confusion above:

image

csmoore commented 7 years ago

This is ready for re-retest in the next build (with/note the behavior mentioned in the last comment)

NatalieCampos commented 7 years ago

i got this one.

NatalieCampos commented 7 years ago

Verified. Any angle over 360 throws an invalid input

image

dfoll commented 7 years ago

This looks like it is fixed. If you start entering a value, say .... 4 then 0 it will draw a preview at 40 degrees. if you continue on to enter 5 (thus trying to create an angle of 405) you get the red X warning and it won't draw when you press enter. Closing this issue, however i am opening a new one, as it seems like mils is not working correctly, from my understanding 405 would be a valid angle when working with mils, but when i switch to mils, i still can not enter a value over 360.