Allow user to create unequally spaced rings through keyboard

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.

Apache License 2.0

17 stars 22 forks source link

Allow user to create unequally spaced rings through keyboard #312

Closed elinz closed 6 years ago

elinz commented 7 years ago

We allow the user to interactively create unequally spaces rings...

It would be very useful to be able to create unequally spaces rings through the keyboard. For user input the user could enter a delimited list of distances, for example...

kgonzago commented 6 years ago

Issue fixed in this PR

dfoll commented 6 years ago

this should also fix #311 I will do all the doc work in this issue

[x] new build of MT
Verify
[ ] Verify issue is fixed in ArcMap 10.3.1
- Creating unequally space rings works correctly
[ ] Verify issue is fixed in ArcGIS Pro 2.1
- Creating unequally space rings works correctly
  Document
[ ] Update checklist test for ArcMap
[ ] Update checklist test for ArcGIS Pro
[ ] Add functionality to DD workflows (probably need a new topic)
[ ] Resources page - add that it is new functionality
[ ] Defense What's New page - add that it is new functionality
[ ] What's New section on homepage add that it is new functionality

BobBooth commented 6 years ago

@kgonzago what happens if the user includes comma delimiters, as in @elinz original issue text? Does the input box handle distances with thousands separator commas? With decimal points (1.4, 2.7, 5.9) KM? What if they get mixed? 5,280.0, 2,640.0, 1,320.0 ?

kgonzago commented 6 years ago

@BobBooth The logic handles commas, spaces and semicolons as delimiters. Numbers 5,280.0, 2,640.0, 1,320.0 like these will be an issue.

lfunkhouser commented 6 years ago

@topowright please comment on why there is additional development needed on this issue?

kgonzago commented 6 years ago

From our review meeting, it was determined the logic to address #312 will be reverted back due to questions regarding the UI. The team agreed the add-in for Rings should follow what was implemented in the D&D widget:

@ACueva @topowright @dfoll @BobBooth Correct me if I'm wrong.

dfoll commented 6 years ago

@lfunkhouser the team met at our review, reviewed the work and made the decision that we want to iterate on this work and have the same experience for the add-in as we do for the widget

@kgonzago correct

kgonzago commented 6 years ago

I will revert this PR which addressed #312

topowright-zz commented 6 years ago

Closing this issue all work for ArcMap and ArcGIS Pro will be done in issue #311

Esri / distance-direction-addin-dotnet

Allow user to create unequally spaced rings through keyboard #312

Verify

Document