search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Distance Calculation should ignore "From" parameter; current tool produces incorrect results (ArcGIS Pro) #324

Closed elinz closed 7 years ago

elinz commented 7 years ago

Tested 1.0 release of Military Tools for ArcGIS.

When users perform a distance calculation, the tool should ignore the "From" parameter. The current tool produces incorrect output if the "From" parameter is set to "Diameter". The tool should always create the graphic based radius no matter what the "From" parameter is set to.

For example, if the "From" is set to "Radius" then the tool produces correct output graphic: 24 hours x 60 miles per hour = 1440 miles. From center point to edge of graphic is 1440 miles (2880 miles diameter) image

If I use the same center point, time and rate, but the "From" is set to "Diameter", the tool produces incorrect output graphic: image

@kgonzago FYI

elinz commented 7 years ago

Note: ArcMap addin creates the correct graphic no matter if "From" is set to Radius or Diameter.

rjones0 commented 7 years ago

@elinz @kgonzago I cannot recreate this in my branch rjones0-207 - pretty sure I spotted it myself and that the fix is included in this PR: https://github.com/Esri/distance-direction-addin-dotnet/pull/326

I've added a note in here to the indicate the fix, just in case it's of interest: https://github.com/Esri/distance-direction-addin-dotnet/pull/326/files

elinz commented 7 years ago

@rjones0 @kgonzago Tested on build 23 Feb 2017 09:05. Verified fixed. Closing issue.