Ambiguous Coord Dialog when using Map Point Tool in GCS Map

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.

Apache License 2.0

17 stars 22 forks source link

Ambiguous Coord Dialog when using Map Point Tool in GCS Map #503

Closed csmoore closed 5 years ago

csmoore commented 6 years ago

With the changes in PR #498 - the addin is now showing the Ambiguous Coordinate Dialog while using the Map Point Tool (in both ArcMap and Pro) if:

the Coordinate Type is set to Default Map Coordinate.
the data frame is using GCS (ex. set data frame to WGS 1984)

The Coordinate was "37.5 -122.8" so does not seem to be ambiguous (so that should be investigated). But we should also prevent this dialog from being shown when the MapPoint tool is being used

Clicking "Don't show me this message again" is necessary to use the tool, but the dialog will be shown again on the next run since the setting does not seem to be saved.

(UPDATE) Additional note - this same issue is also causing several of the unit tests to fail:

csmoore commented 6 years ago

Moving this into next sprint (hopefully this is OK) since it is something that broke while fixing #218, #220, #222

csmoore commented 6 years ago

Addressed in #517 and https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/481

Can be QA/QC'd after merge (note: both manual and automated tests)

BobBooth commented 6 years ago

Updated checklist test. PR: https://github.com/ArcGIS/solutions-defense-test-catalog/pull/92

lfunkhouser commented 6 years ago

Issue cannot be "done" until the tasks are completed. @BobBooth if you tested this issue and verify that it has been fixed, please add a comment of how this item moved from the Sprint backlog to done, add the closing E-label, and remove the yellow task labels that you completed.

BobBooth commented 6 years ago

Completed manual checklist testing, following the steps here: https://github.com/ArcGIS/solutions-defense-test-catalog/blob/master/Tests/Distance-Direction_ArcMap.md Issue 503 Check https://github.com/Esri/distance-direction-addin-dotnet/issues/503 Start a new map, set the data frame coordinate system to WGS84, add a basemap.

Enter the following coordinate in the Starting Point box on the Line tab: 37.5 -122.8 You should not get an "ambiguous coordinate" warning. Enter the following coordinate in the Ending Point box on the Line tab: 37.5 -125 The line should be created. Enter the following coordinate in the Starting Point box on the Line tab: 37.5 -122.8 You should not get an "ambiguous coordinate" warning. Click the Map Point tool and click to create another line from that start point. The line should be created. -=-=

Did not get warning messages, coordinates were accepted, lines were created as desired.

lfunkhouser commented 5 years ago

This issue is back with the latest version of dev

csmoore commented 5 years ago

This is a new issue discoved while testing #503 - Opened #667 with the specifics of this new issue.