Distance and Direction Circle tool causes ArcMap/Pro go unresponsive click outside basemap extent

[lfunkhouser]

From @BobBooth on September 26, 2017 20:39

Testing DD (2.1.1) Circle tool on ArcMap 10.6 (8184), had added the Topographic Basemap from AGOL. Clicked add point tool, added a couple of circles by clicking a point on the map, then clicking to define the radius. Clicked outside of the extent of the basemap. A point is added to the display. Clicked back on the basemap. ArcMap become unresponsive.

Copied from original issue: ArcGIS/solutions-defense#437

[lfunkhouser]

From @BobBooth on September 26, 2017 20:52

This problem does not affect the interactive tools for adding lines. They seem perfectly happy if you click outside of the basemap extent, and add a line from that (hypothetical?) location if you click somewhere in the basemap extent for the second point. The Ellipse tool and the Rings tools both do suffer from this problem.

[lfunkhouser]

From @BobBooth on September 29, 2017 18:35

This problem exists in the tools in the combined Military Tools add-in as well.

[lfunkhouser]

From @kgonzago on January 18, 2018 14:4

@BobBooth I'm looking into this issue. Does this issue occur in 10.5+ as well?

[lfunkhouser]

From @kgonzago on January 18, 2018 14:53

FYI: I was able to reproduce this issue in ArcMap 10.5.

[lfunkhouser]

From @kgonzago on January 22, 2018 18:51

Fix is in this PR

[lfunkhouser]

From @kgonzago on January 22, 2018 19:15

@BobBooth can you verify when you have a chance?

[lfunkhouser]

From @kgonzago on January 22, 2018 21:0

I added a step to build MT Desktop add-ins in the 3.0 Build and encountered exceptions. Tagged this issue as impeded since the slave associated with the build does not have ArcObjects SDK installed. AO SDK issue has been logged.

[lfunkhouser]

From @topowright on January 24, 2018 0:11

We need to address this with the new build of Military Tools for ArcGIS .

[csmoore]

This was fixed in PR #491 - removing dev label and ready for QA/QC

[BobBooth]

This is working correctly.

[BobBooth]

Added test to cover this to my PR on DD checklist test. @ACueva @topowright

[csmoore]

Also note that in PR #538 - @garys-esri found a similar issue in Pro so please test in both ArcMap and Pro:

Repro steps: "To test this behavior and this fix, build the add-in, deploy in ArcGIS Pro, and use the Circle tab of the Distance and Direction add-in to draw a circle on a 2D map. When you move the mouse west of -180 degrees longitude, ArcGIS Pro crashes without this fix. With the fix, the circle stops drawing and the distance value stops changing until the mouse is back on the map."

[garysheppardjr]

That PR number is #538, not 528.

[topowright-zz]

This is still an issue in ArcGIS Pro being that we do not get the same message box that we get in ArcMap

Steps to Reproduce:

1. Open ArcGIS Pro
2. Add a map
3. Open the DD Tool
4. Select the circle tab
5. Drop a point outside the map
6. Enter in a size of the circle
7. Hit enter

Here is my results:

[csmoore]

Addressed in PR #546

Should look like this now in both ArcMap & Pro - and reset if 1st point out of bounds:

[BobBooth]

Tested latest build MT (4/17/18) Circle tool in ArcMap 10.5. Circle tool is fixed. Tested on Pro 2.1, tool works the same way, gives "out of bounds" error message.

[BobBooth]

@dfoll @ACueva I believe this can be moved to Done, once the two checklist test PRs are merged. https://github.com/ArcGIS/solutions-defense-test-catalog/pull/121 https://github.com/ArcGIS/solutions-defense-test-catalog/pull/122

[ACueva]

PR https://github.com/ArcGIS/solutions-defense-test-catalog/pull/121 and https://github.com/ArcGIS/solutions-defense-test-catalog/pull/122 reviewed and merged.

Moving issue to Done.

[topowright-zz]

@ACueva I think this needs a verified tag on this item. Can you place a verified tag on this?

[topowright-zz]

Awesome.