search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Inital Commit for the new Visibility widget #515

Closed kgonzago closed 6 years ago

kgonzago commented 6 years ago

Issue by lyle6003 Tuesday Feb 06, 2018 at 16:11 GMT Originally opened as https://devtopia.esri.com/WebGIS/arcgis-webappbuilder/pull/11759

@Juns6831 this is the initial commit for the Visibility widget created by Defense Solutions. The work for this widget can be tracked in the following issue:
https://devtopia.esri.com/WebGIS/arcgis-webappbuilder/issues/11701

lyle6003 included the following code: https://devtopia.esri.com/WebGIS/arcgis-webappbuilder/pull/11759/commits

kgonzago commented 6 years ago

Comment by Juns6831 Wednesday Feb 07, 2018 at 01:17 GMT

This widget includes some python and gdb files, can you remove them from the widget if they are not required when run the widget? The widget in WAB is supposed to include JS/CSS/HTML/MD files and some unit tests files.

kgonzago commented 6 years ago

Comment by lyle6003 Wednesday Feb 14, 2018 at 10:40 GMT

The un necessary files for this workflow have been removed.

kgonzago commented 6 years ago

Comment by lyle6003 Friday Feb 16, 2018 at 17:00 GMT

@Juns6831 We have submitted all code changes and things asked per the review meeting. Please let us know what the next step we need to take.

kgonzago commented 6 years ago

Comment by Juns6831 Thursday Feb 22, 2018 at 01:32 GMT

You'd better not use ${nls.abc} in data-dojo-props in HTML template because this may break in some languages.

kgonzago commented 6 years ago

Comment by Juns6831 Thursday Feb 22, 2018 at 01:34 GMT

Found you use jquery in your widget, and there is a jquery in stemapp/libs, can you check whether you can use it? If you use the lib in stemapp, your widget will be more lightweight.

kgonzago commented 6 years ago

Closing issue since it was added to the wrong repo.