search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Label DD Lines in Pro #542

Closed dfoll closed 6 years ago

dfoll commented 6 years ago

Background

Users need to have labels on features created by Distance and Direction.

Current State

We are unable to create labels for any features being created for Distance and Direction in ArcGIS Pro.

Expected Result

Functionality is implemented Tests written Tested on Pro 2.1, 2.2 Tested in Distance and Direction 2.1 and 2.2 Tested in Military Tools 2.1 and 2.2 Documented in Distance and Direction and Military Tools

Tasks to be done - Last update 25 May 2018

Verify

Background information

location of the layer package https://github.com/Esri/distance-direction-addin-dotnet/compare/csm/%23541-pro-features

BobBooth commented 6 years ago

I have a draft set of layer packages (using Arccade, with schema to support labeling) that I started before the planning meeting, and just wrapped up. Will submit a PR to the repo. @dfoll - would you mind having a look? I looked at the Circle LPK arcade expression and adapted it to match the ArcMap line style.
PR is https://github.com/Esri/distance-direction-addin-dotnet/pull/563

BobBooth commented 6 years ago

I am taking off the Design tag, on the assumption that matching the labels for DD lines in ArcMap and the arcade expression from the Circle LPKX is correct.

csmoore commented 6 years ago

@BobBooth @dfoll - Please see note about the LPKX in PR #563 - https://github.com/Esri/distance-direction-addin-dotnet/pull/563#issuecomment-391511380 - there is a difference between the datamodel for the LOB lines in that PR and the datamodel created by the SaveAs FeatureClass/Shapefile - so I just wanted to make sure that was intentional:

image

csmoore commented 6 years ago

Dev work started in https://github.com/Esri/distance-direction-addin-dotnet/tree/csm/%23542-pro-line-features-labels

Another issue I noticed with the "Lines of Bearing" layer package (now at: https://github.com/Esri/distance-direction-addin-dotnet/tree/csm/%23541-pro-features/source/addins/ProAppDistanceAndDirectionModule/ProAppDistanceAndDirectionModule/Data ) is that the Geo Lines apparently have Z values so can't currently be stored in this feature class. I can jump through some hoops to removes these Z's but you may want this support.

To summarize the current issues with the "Lines of Bearing" layer:

  1. Differences between lines export datamodel and currently implemented
  2. Should support Z's

Moving issue to impeded for team to decide on those 2 issues.

BobBooth commented 6 years ago

@csmoore will revise, sorry. Didn't look at the output from Save As. Will Z enable.

BobBooth commented 6 years ago

I am re-doing the LPKXs with the output from Save As and Z values.

BobBooth commented 6 years ago

I reviewed the manual checklist test, added a PR for Save As feature/KMZ output in Cucumber style: https://github.com/ArcGIS/solutions-defense-test-catalog/pull/146

csmoore commented 6 years ago

Using the latest layer package - got a little further but hit this familiar problem when using the schema-only lpkx:

image

The workaround to the problem - the same problem we had here: https://github.com/Esri/military-features-data/issues/287 is to run the Add Spatial Index GP tool prior to packaging the schema-only lpkx. Just not sure how/why this problem still exists.

Adding the workaround - LOBs should look like this now - I'll add a PR now ( PR #570 ) with just the current/working "Distance_And_Direction.lpkx" we should all be working from.

image

csmoore commented 6 years ago

The dev work for this is currently in PR #571 - removing dev label

csmoore commented 6 years ago

Resuming dev to do PR rework mentioned here: https://github.com/Esri/distance-direction-addin-dotnet/pull/571#issuecomment-392126556

csmoore commented 6 years ago

PR #571 rework should now be complete - removing dev label

topowright-zz commented 6 years ago

Reviewed the documentation and there does not need to be any changes to any workflows related to the lines tab.

lfunkhouser commented 6 years ago

The functionality to label lines by distance and bearing will be handled in issue #576 . Removing the dependency and the task to fix this issue from this issue, Label DD Lines in Pro.