search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Distance Calculator labels Diameter incorrectly #569

Closed ACueva closed 6 years ago

ACueva commented 6 years ago

Environment: ArcGIS Pro 2.2 Daily Distance and Direction 3.0 Build 6 from Military Tools

Steps to reproduce:

  1. From the Circle Tab select "Radius"
  2. Enter Center Point: 32° 41' 41.87"N 117° 7' 30.39"W
  3. Expand Distance Calculator
  4. Enter a Time of: 2 hours
  5. Rate of 60 Miles/hour

A circle with a label of Radius: 120 Miles should draw.

Repeat the same steps listed above, this time change the Radius to Diameter. A circle of the same size will draw, the label will be Diameter: 120 Miles.

The attribute field for the circles created will show the distance listed as "120" for both of these circles created. 2018-05-24_16-21-46

FYI @csmoore, Can you chime in with a level of effort to address this issue?

csmoore commented 6 years ago

@topowright asked me to look at this issue. I can reproduce the issue. As shown above - the radius is the correct measurement and the diameter is incorrect (should be doubled).

@topowright - is this the next issue I should work on?

image

csmoore commented 6 years ago

Was asked by @topowright to work on this next so dependent circle issue #540 could be closed out - moving to in progress for dev work

csmoore commented 6 years ago

Moving back - was requested to do some rework on PR #571

csmoore commented 6 years ago

Addressed in PR #578

BobBooth commented 6 years ago

Checklist test updated to cucumber test style and connected to issue 569 in PR: https://github.com/ArcGIS/solutions-defense-test-catalog/pull/147

ACueva commented 6 years ago

PR #578 merged, kicking off new MT build in Jenkins to test.

ACueva commented 6 years ago

Tested locally on Esri/csm/#569-bad-diameter-label branch: 2018-05-29_9-40-43

ACueva commented 6 years ago

Verified in Military Tools build 8. 2018-05-29_10-11-03 2018-05-29_10-10-50

ACueva commented 6 years ago

@csmoore This box appears to be calculating incorrectly. 2018-05-29_10-14-34

Radius appears to calculate the value fine. 2018-05-29_10-16-28

csmoore commented 6 years ago

@ACueva - I didn't think you could enter anything in the Radius/Diameter box with the Distance Calculator expanded (it should be disabled) so I might need you to show me or provide the repro steps for how you did that (I can't seem to do)

ACueva commented 6 years ago

Worked with @csmoore, unable to repro this case. Removing development label. Marking this issue verified as well.