Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Out of bounds clicks for Lines tab interactive construction not handled correctly #634

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

In Pro, the Distance and Direction addin is not handling "out of bounds" clicks when interactively constructing lines.
I can click in the Pacific, zoom out to see the western edge of the basemap, drag a line across it, and click in the whitepace outside of the basemap extent. Should get an "out of bounds" message, but do not. The line is created with incorrect "nan" length. image

In contrast, the interactive construction methods for Circles, Ellipses, Rings are behaving correctly, popping up the out of bounds error when you stray outside of the basemap extent.

image

We have fixed "out of bounds" issues before, here: https://github.com/Esri/distance-direction-addin-dotnet/issues/512 and here: https://github.com/Esri/distance-direction-addin-dotnet/issues/535

I tested the released version of Distance and Direction on Pro 2.1, and I am seeing the same behavior (click out of bounds creates line with nan length). I also tested the released version in ArcMap 10.3.1 and the "out of bounds" message is displayed correctly in ArcMap. This seems to be an issue that was found and fixed in ArcMap, but not identified in Pro. It is not a new issue in Pro with the recent PR.


UPDATE: This is also an issue on Rings Tab when the "Origin" and "Cumulative" options are used

csmoore commented 5 years ago

While testing this with an existing Pro project I got the dreaded "Spatial Index Grid Size" error that we have seen previously in Pro with lpkxs ( https://github.com/Esri/military-features-data/issues/287 ) - not sure if this is a new issue at Pro 2.3, but will write a new issue for this:

image

csmoore commented 5 years ago

Addressed in PR #650

dfoll commented 5 years ago

Built

Doc updated

dfoll commented 5 years ago

@BobBooth ready for doc qc

BobBooth commented 5 years ago

Verified issue in tables on solutions dev MT and DD and in PDFs for each.