search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Remove "Reactive" dependency #640

Closed jmccausland closed 5 years ago

jmccausland commented 5 years ago

This PR should allow you to remove the "Reactive" dependency from the Pro project. It was only using one class/method (Subject.Sample) to throttle the mouse movement handler to keep things perform-ant. Sharing a class here that we created recently to do the same thing, enjoy.

Please be sure to test thoroughly before merging.

jmccausland commented 5 years ago

@csmoore please review and let me know if this is something that can be merged before our release on the 25th of this month.

csmoore commented 5 years ago

@jmccausland - many thanks for changes, I'll check with @lfunkhouser and @kgonzago to see if OK to do just before release

kgonzago commented 5 years ago

@jmccausland Thanks for the help.

@csmoore My suggestion is to merge after our release.

jmccausland commented 5 years ago

@lfunkhouser @csmoore @kgonzago This was a simple replacement and our project uses the same throttle method. Very low risk.

csmoore commented 5 years ago

Kicked of build to test but got an error on VS2013 (needed to build addins for 10.3), so looking into this:

Helpers\DebounceDispatcher.cs(20,53): error CS1519: Invalid token '=' in class, struct, or interface member declaration [c:\jProd\workspace\Addins\DD\DD_testing\distance-direction-addin-dotnet\source\addins\DistanceAndDirectionLibrary\b0d5o1pz.tmp_proj]
Helpers\DebounceDispatcher.cs(20,79): error CS1519: Invalid token '(' in class, struct, or interface member declaration [c:\jProd\workspace\Addins\DD\DD_testing\distance-direction-addin-dotnet\source\addins\DistanceAndDirectionLibrary\b0d5o1pz.tmp_proj]

Probably something we need to revert to C# 5 syntax

csmoore commented 5 years ago

Revert code to C# 5 for VS 2013 and created build at:

Solutions\DefenseSolutions\DistanceAndDirection\Testing\jrm-remove-reactive-depends\15\

csmoore commented 5 years ago

Created build Solutions\DefenseSolutions\DistanceAndDirection\Testing\jrm-remove-reactive-depends\17\ to test. It looks like this change only affects Pro so only needs testing there.