search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Distance and Direction rounds input coordinate values to two decimal places #644

Closed BobBooth closed 5 years ago

BobBooth commented 5 years ago

Distance and direction input coordinate text box is rounding coordinate values to two decimal places (behind the scenes... values look right in box, but are rounded in output geometry) this happens on all tabs that create point locations (start points for Distance and Bearing lines, center points of circles, ellipses, rings. For example, if you enter: -121.842673,36.589155 it gets rounded to -121.84,36.59

Tested with MT test data, created Distance and Bearing lines using the GP tool and the Table to Line of Bearing CSV. The first row of that table creates a line of bearing starting at -121.842673,36.589155 If you open up Distance and Direction and create a Line using Distance and Bearing, and enter the starting value of -121.842673,36.589155 and the Distance of 2081.72 and angle of 100.29 and create the line, you will get two parallel lines. image

If you switch to Circle and enter a center point of -121.842673,36.589155, you will see the spot for the center of the circle at the start point of the DD created bearing line. image

Zoom in close to it and hover pointer over it, and you will see it is at -121.84,36.59

Click Identify on line, OriginX and OriginY are rounded. image

Zip of a PPKX with repro data attached. DD_Input_value_rounding.zip

Patrick S pointed this out to me, and I confirmed it is happening. He saw it with MT 3.3.0.199, Pro 2.3 I verified it is happening with DD 4.1.1.41 (recent dev build), Pro 2.3

Also seeing this in ArcMap 10.3.1 with MT 3.3.0.199 image

This defect was present in the September 2018 build of MT.

csmoore commented 5 years ago

This was an issue in Coordinate Conversion Library call GetCoordinateString that was addressed in a PR in that repo https://github.com/Esri/coordinate-conversion-addin-dotnet/pull/576

This issue can be tested after that PR is merged and D&D add is rebuilt

BobBooth commented 5 years ago

Tested from DD Dev after merging CC RE#576, this issue is fixed on ArcGIS Pro 2.3: image.png and on ArcMap 10.3.1: image.png

BobBooth commented 5 years ago

I have updated the doc to include, on the Resources tab, a Distance and Direction March 2019 page, listing the issue addressed. Also updated the PDF and the MT Resources for March 2019. Nav on DD will work after YAML edits and DD will be listed in the What's New after PR (https://github.com/ArcGIS/arcgis-solutions-website/pull/7549) gets merged by @dfoll

BobBooth commented 5 years ago

Added checklist test for this issue, PR here: https://github.com/ArcGIS/solutions-defense-test-catalog/pull/200 @dfoll

BobBooth commented 5 years ago

Leaving Doc tag on until tab nav is working. Removing QC- manual tag, as I built it from Dev and check, it was working.

BobBooth commented 5 years ago

Tab nav issue is now fixed. Only waiting on the PR to be merged for What's New content to show up.

BobBooth commented 5 years ago

The doc is now current on Dev.