search

Esri / distance-direction-addin-dotnet

Add-in provides the ability to easily and quickly create geodesy lines, circles, ellipses and range rings.
Apache License 2.0
17 stars 22 forks source link

Using add-in with existing ArcGIS Pro project at a different scale causes "Spatial Index Grid Size" error #648

Closed csmoore closed 5 years ago

csmoore commented 5 years ago

Repro steps:

  1. Create a new Pro project
  2. Zoom into the Monterey Peninsula
  3. Create a line, circle, ring the approximate size of the peninsula
  4. Exit Pro (Save the Project)
  5. Run Pro and open the previously created project
  6. Zoom to world scale
  7. Attempt to create a line at world scale
  8. "Spatial Index Grid Size is Invalid" Error is reported and line can't be created

image

We have seen this error before in Pro with lpkxs ( https://github.com/Esri/military-features-data/issues/287 ) - but this issue is slightly different, it seems like when you save a Pro project it is setting a spatial index on the GDB, not sure if this is a new issue at Pro 2.3, or we just never noticed previously.

Note: I confirmed that these steps also create the same failure with the Military Symbol Editor (create a Military Line symbol instead of a D&D line)

lfunkhouser commented 5 years ago

Need to check on previous version of Pro to see if this is a Pro 2.3 change. Also, check to see if a regular edit session behaves this way without the DD add-in.

csmoore commented 5 years ago

Testing this on 2.4 and I am experiencing some lockups and/or odd behavior (zooms to world extent after adding) loading the layer package and activating the Map Tool at full extent (I don't see this on my 2.2 machine) - so investigating this

csmoore commented 5 years ago

On Pro 2.4.19901 I am seeing an issue where when I try to draw the first graphic, the map zooms to full extent and then when I manually zoom back to the original area, 3 graphics are draw.
@saip can you try this on your latest Pro build?

image

[UPDATE] - we tracked this down to a problem with the lpkx - fixed here: #662

csmoore commented 5 years ago

@saip - @ljuru and I stepped through the repro steps in the original issue on Pro 2.4.19921 on 2 different machines but we are still seeing the lockup issue mentioned previously - can you try this? This did test OK on 2.2. and 2.3, just not 2.4

csmoore commented 5 years ago

Verified that with PR #658 the error is not received - still investigating a possible deadlock issue on 2.4 unrelated to this PR

csmoore commented 5 years ago

I was able to reproduce the lockup issue outside of the D&D addin, so I do not believe it is related to our addin and we will pass these repro-steps onto the Pro team (both @dfoll and I repro'd this issue)

Repro Steps:

  1. Close any Pro instances
  2. Open the Pro Package provided in Pro 2.4 (tested on version after 2.4.19921) - "Test-DD-Lockup.ppkx.zip"
  3. Click the Full Extent Button
  4. Click the Insert Tab
  5. The UI behaves strangely, some things work, but the tools are all grayed out and none of the tools can be selected

Update:

  1. Working with core, they identified that this is a labeling issue with this specific geometry and label placement type ("River") when the display is zoomed out beyond 1:23M.
  2. The geometry is created here: https://github.com/Esri/distance-direction-addin-dotnet/blob/dev/source/addins/ProAppDistanceAndDirectionModule/ProAppDistanceAndDirectionModule/ViewModels/ProRangeViewModel.cs#L357
  3. The label placement causing the problem is:

image

dfoll commented 5 years ago

We believe this was fixed in Pro 2.4 final. We believe this only needs to be confirmed as fixed and then listed as an issue addressed. Additionally, this is not an issue on 2.2, and 2.3.

dfoll commented 5 years ago

ArcGIS Pro 2.4.0 b1 (19489) + DD build 91

ArcGIS Pro 2.4.0.19948 +DD build 91

dfoll commented 5 years ago

certification test updated in this pr

dfoll commented 5 years ago
lfunkhouser commented 5 years ago

Verified in issues addressed for DD and MT on staging Verified in PDFs in dev builds of DD 95 and MT 313

dfoll commented 4 years ago

this issue may have crept back in for arcgis pro 2.6. have not done a ton of research at this point....info for build that made me think this is 2.6.23.681 and ArcGIS.Desktop.Defense built on 24March. Couldn't immediately repro without spending time dedicated to sitting down and reproing, but i did notice this message. first step will be trying the repro steps in this issue.