search

Esri / dynamic-situational-awareness-qt

Dynamic Situational Awareness Qt
Apache License 2.0
56 stars 21 forks source link

Update real time feeds to make use of dynamic entities custom data source #367

Closed ldanzinger closed 1 month ago

ldanzinger commented 1 year ago

Summary

DSA simulates real time data feeds with a message simulator that sends GeoMessage and Cursor On Target messages. The DSA app listens to a UDP port and displays the messages as graphics on the screen. If the message is an update to an existing graphic, the graphic attributes and geometry will be updated.

DSA was written before Runtime/Maps SDK had official support for real time feeds. Since then, we've added dynamic entities, which allow you to hook into stream services, as well as custom data sources.

We should update DSA to make use of custom data sources to use official best practices instead of the hand-rolled graphics implementation. In the end, the message feeds should be represented by DynamicEntityLayer with DynamicEntityDataSource instead of GraphicsOverlay.

All work should be done off of the v.next branch, which will build with Qt 6.5.1 and Maps SDK 200.2.

Definition of done

kerryrobinson commented 4 months ago

Instead of creating a new issue, I'll add a comment here on issues/bugs I've noticed with the update to use Dynamic Entities, since it is not merged yet. We can determine if we need to turn any of these into new issues.

1- The Message Feeds panel lists duplicates of the 7 feeds. The bottom set of feeds in the list do not have any effect on turning on or off the visibility of the feeds (only the top set). I noticed that this only happens the first time I open the app and if there hasn't already been a config file created. Once the config file is created, I cannot reproduce this issue.

This is now covered in issue https://github.com/Esri/dynamic-situational-awareness-qt/issues/376

image

2 - Dynamic Entities layers show up in the Overlays panel, when they should only appear in the Message Feeds panel. (note these are also duplicated when the app opens for the first time without an existing config file present)

This is now covered in issue https://github.com/Esri/dynamic-situational-awareness-qt/issues/373

image

3 - Long-pressing on a dynamic entity in a feed results in an app crash

No longer happening.

4- The Conditions list says there are no conditions, even though there is one condition saved in the config file (the default condition to highlight any Land Friendly Tracks that have a status of 1).

No longer happening

5- The Conditions and Observations Report panels UIs needs to be updated. The text on the Back and Next buttons are not visible (instead you see ellipses). Also, hitting the X at the bottom ('Cancel') does not cancel the panel (hitting the X in the upper right-hand corner does). image

New issue created

6- Conditions no longer seem to be working at all. The Dynamic Entity layers will need to be hooked up (they can be treated as graphics so it should technically be possible), but also My Location doesn't seem to be working after setting up a spatial condition. (eventually we should support Geotriggers but for now I recommend seeing if we can hook up Dynamic Entities to work with the existing Conditions/Alerts capability in the app). Conditions looking good so far

7- Running the Line of Sight tool on the 3D observers data crashes the app. I was only able to repro this once.

New issue created for this

8- Make sure to update the About dialog to reference the latest version of the SDK used and version of the app (still 2.0.0?)

New issue created

kerryrobinson commented 1 month ago

Work has been done to update to use DE's. @kerryrobinson to just review and make sure that any remaining bugs are represented in other issues and close this.

kerryrobinson commented 1 month ago

I've done a review and have made sure that any lingering issues are logged as separate issues in the Project board. Closing this issue now since the main work to upgrade to Dynamic Entities has been done.