search

Esri / ember-cli-amd

Ember CLI Addon for using AMD libraries
Apache License 2.0
21 stars 15 forks source link

Inject baseUrl to allow use of cdn-ed assets #11

Closed dbouwman closed 9 years ago

dbouwman commented 9 years ago

Open Data uses ember-cli-deploy and sends all assets to a separate cdn location. When we upgraded to the 0.4.0 release, things broke because the paths to the amd assets were relative to index.html, and thus incorrect.

This PR also adds a CHANGELOG.md file with a description of this change, as well as updates to the README.md with a descriion of how this works in conjunction with ember-cli-deploy

ffaubry commented 9 years ago

@dbouwman thanks a lot. Do you really need the console log? We are not using console log in the rest of the code.

dbouwman commented 9 years ago

gah! Thanks @ffaubry - I'll remove those and re-sync

ffaubry commented 9 years ago

@mjuniper You may want to pull this one and test on your side. @dbouwman I will pull your repo and test it on my side.

ffaubry commented 9 years ago

@odoe I pulled dave's code and it builds correctly. :+1:

dbouwman commented 9 years ago

@ffaubry I'm testing this using the same app as @mjuniper so we are good on this end :)