Esri / esri-eds

Apache License 2.0
2 stars 0 forks source link

About page hero should have a max-height #255

Closed alexcarol closed 1 month ago

alexcarol commented 1 month ago

Current: https://main--esri-eds--esri.aem.page/fr-fr/about/about-esri/overview Live: https://www.esri.com/fr-fr/about/about-esri/overview

twhite313 commented 1 month ago

Does't need max-height so much as content | image sections need to be aligned better. Wonder if it wouldn't be better to switch to grid and set up some template areas?

alexcarol commented 1 month ago

Does't need max-height so much as content | image sections need to be aligned better. Wonder if it wouldn't be better to switch to grid and set up some template areas?

I think there's two different issues that we're discussing, one is that in regular displays the grid is slightly different: EDS: image Live: image

The issue mentioned here is that on wider displays the height is limited on the live site: EDS: image

Live: image

In any case, both issues should be addressed.