search

Esri / esri-leaflet-cluster

Plugin for Esri Leaflet that clusters a Feature Layer using Leaflet.markercluster
http://esri.github.io/esri-leaflet/
Apache License 2.0
23 stars 23 forks source link

node-sass at v4.7 - Build Failed #32

Closed gavinr closed 4 years ago

gavinr commented 4 years ago

Why do we have node-sass locked at v4.7? I'm guessing there was some sort of security issue at the time @jgravois? As-is I get an error when I run npm install and it tries to install node-sass ... can we change this back to "node-sass": "^4.9.0",?

Done Building Project "C:\.....\esri-leaflet-cluster\node_modules\node-sass\build\binding.vcxproj" (default targets) -- FAILED.

Done Building Project "C:\.....\esri-leaflet-cluster\node_modules\node-sass\build\binding.vcxproj.metaproj" (default targets) -- FAILED.

Done Building Project "C:\.....\esri-leaflet-cluster\node_modules\node-sass\build\binding.sln" (default targets) -- FAILED.

Build FAILED.
jgravois commented 4 years ago

i have no clue. upgrading should definitely be safe.