search

Esri / esri-leaflet-cluster

Plugin for Esri Leaflet that clusters a Feature Layer using Leaflet.markercluster
http://esri.github.io/esri-leaflet/
Apache License 2.0
23 stars 23 forks source link

Changed bindPopup provided callback argument to layer object #8

Closed tyleralves closed 8 years ago

tyleralves commented 8 years ago

Reference esri/esri-leaflet#828 for discussion

jgravois commented 8 years ago

wouldn't it be better to just rip the bindPopup() and unbindPopup() methods and tests out entirely?

tyleralves commented 8 years ago

Yea, removing them entirely is the way to go. I shied away from that because I couldn't figure out how to modify the tests but I guess now that the methods belong solely to Leaflet, their tests should suffice(?).

jgravois commented 8 years ago

yup.

"The best commits have more red than green" - @tomwayson