Esri / esri-leaflet-doc

Documentation, API Reference and Samples
https://esri.github.io/esri-leaflet/
Apache License 2.0
81 stars 1.12k forks source link

Local doc site point to local esri-leaflet.js #279

Closed gavinr closed 4 years ago

gavinr commented 4 years ago

Sometimes as part of smoke-testing it's a good step to run all the sample pages in the documentation against a new build that of esri-leaflet.js that you have locally. I haven't found a great way to do this - is there a method to do this that I'm missing?

If not, it would be nice if we could modify the esri-leaflet-doc code so that it's easy to point your local build of the documentation pages temporarily to use a local esri-leaflet.js file.

pmacMaps commented 4 years ago

I would add that it would be nice to test a local build of doc pages against all of the official esri-leaflet plugins. I ran into this issue with a recent update I made to the geocoders plugin.

It looks like this functionality may already exist:

jgravois commented 4 years ago

@pmacMaps is right. there's definitely room for improvement there.

gavinr commented 4 years ago

@jgravois looks like by default it looks at /js/linked/leaflet-dist/... ... how does that folder get created? Or is that a manually created symlink or something?

for my situation, i'd like that to link to http://localhost:5000/dist/esri-leaflet-debug.js ... maybe I'll add a localSourcePath property setting to devSiteData.json

jgravois commented 4 years ago

is that a manually created symlink

exactly. it's just a hacky solution I came up with before I knew about npm link. anything you feel like doing to improve the DX would be appreciated.