Esri / esri-leaflet-geocoder

helpers for using the ArcGIS World Geocoding Service in Leaflet
http://esri.github.io/esri-leaflet/examples/geocoding-control.html
Apache License 2.0
244 stars 101 forks source link

Update imported version of esri-leaflet to 3.0.2 #272

Closed jon571 closed 3 years ago

jon571 commented 3 years ago

Esri-leaflet recently made a change here: https://github.com/Esri/esri-leaflet/commit/a6a46fca47dba7bae12b54bcaddf37963d3b55b0

This is to stop an error issued by webpack 5, in my case after upgrading to angular 12: ./node_modules/esri-leaflet-geocoder/node_modules/esri-leaflet/src/EsriLeaflet.js:2:0-51 - Error: Should not import the named export 'version' (reexported as 'VERSION') from default-exporting module (only default export is available soon)

gavinr commented 3 years ago

I think you can do this yourself - just run:

npm install
npm install esri-leaflet@3.0.2
jgravois commented 3 years ago

you can, but 3x is outside the SemVer range defined in the package.json https://github.com/Esri/esri-leaflet-geocoder/blob/master/package.json#L13

gavinr commented 3 years ago

Ah, good point. I suppose we should have included that ("esri-leaflet": "^3.0.0") in v3.0 release.

jgravois commented 3 years ago

meh. live and learn! 😸

jon571 commented 3 years ago

Any idea when there might be a release available on npm for this?

Cheers :-)

gavinr commented 3 years ago

This was released in v3.1.0