search

Esri / esri-leaflet-geocoder

helpers for using the ArcGIS World Geocoding Service in Leaflet
http://esri.github.io/esri-leaflet/examples/geocoding-control.html
Apache License 2.0
243 stars 97 forks source link

Build update - SASS #306

Closed JeffJacobson closed 1 year ago

JeffJacobson commented 1 year ago

Resolves build error described in #305

patrickarlt commented 1 year ago

@JeffJacobson this looks good but node-sass is deprecated now. Would you be willing to switch this to sass? If not I'll merge this and make a note to switch later.

JeffJacobson commented 1 year ago

@JeffJacobson this looks good but node-sass is deprecated now. Would you be willing to switch this to sass? If not I'll merge this and make a note to switch later.

I'll take a little time to see if I can implement the change to sass. If I can get it working I'll push to this pull request's branch.

If you don't hear back from me in a day or two, then I would suggest you merge and "make a note to switch later". The build issue I addressed is a hindrance to any other devs that want to contribute to the project, so I think it's pretty important.

JeffJacobson commented 1 year ago

Should I also remove the bower and/or travis-ci configs?

I think bower would be safe to remove, but I didn't know if you're still using travis-ci.com rather than the discontinued travis-ci.org.

I won't remove either unless you tell me otherwise.

patrickarlt commented 1 year ago

I would just leave bower and travis ci alone. I cant remember off the top of my head and it outside the scope of this issue. Thanks for contributing!

JeffJacobson commented 1 year ago

OK, I think it's all done now.

gavinr commented 1 year ago

This was released in v3.1.4.