search

Esri / esri-leaflet-vector

Display ArcGIS Online vector basemaps w/ Esri Leaflet
Apache License 2.0
56 stars 57 forks source link

Vector tile layer attribution issues #142

Closed ItaiEinhorn closed 2 years ago

ItaiEinhorn commented 2 years ago

Describe the bug

  1. The same issue with the missing 'Powered by Esri' attribution is occurring in VectorTileLayers This issue: https://github.com/Esri/esri-leaflet-vector/issues/133 Was fixed here: https://github.com/Esri/esri-leaflet-vector/pull/135 This was fixed on the VectorBasemapLayer entity, i believe the same code should be applied to VectorTileLayer entity as well see this codepen example: https://codepen.io/ItaiE/pen/dymgzLE (Esri Leaflet Vector basemap - via item ID - doesn't have 'Powered by Esri' attribution)

  2. The reason i didn't use the VectorBasemapLayer entity is because i found another issue: When removing the VectorBasemapLayer from the map, the attribution doesn't get cleared and so when loading a new layer, the old attribution remains. See the codepen for reference: https://codepen.io/ItaiE/pen/KKoGvqg Clicking on the 'Remove Layer' button will remove the VectorBasemapLayer but not it's attribution

Reproduction

https://codepen.io/ItaiE/pen/dymgzLE

https://codepen.io/ItaiE/pen/KKoGvqg

Logs

No response

System Info

Latest

Additional Information

No response

gavinr commented 2 years ago

Thank you for the report.

For your issue 1, I think you're correct - we should make that change. For your issue 2, I think that's already covered here: #136, correct?

Thanks!

ItaiEinhorn commented 2 years ago
  1. Thank you
  2. Indeed, 136 seems to cover it
gavinr commented 2 years ago

Ok, closing this in favor of #143. Thank you!