search

Esri / esri-leaflet-vector

Display ArcGIS Online vector basemaps w/ Esri Leaflet
52 stars 53 forks source link

Fix: Token with sprite and glyphs #192

Closed gavinr-maps closed 11 months ago

gavinr-maps commented 1 year ago

This PR puts in a fix to properly add the token for sprites and glyphs, as pointed out in #188 and #186.

  1. As part of this PR, I wanted to unit test the formatStyle function in Util.js. To do this, I had to export that function. So that's what I did first: https://github.com/Esri/esri-leaflet-vector/pull/192/commits/ba913e71571d193144e3e3d075f945afd34c98a2
  2. Then I added a unit test to demo the sprites issue: https://github.com/Esri/esri-leaflet-vector/pull/192/commits/405d991042a4091472fcbb5d21a73e4a94837da3
  3. Fix for that ^ sprites issue: https://github.com/Esri/esri-leaflet-vector/pull/192/commits/b0d7815be3736c8c73523f1b00350139e5a56559
  4. Then I added a unit test to demo the glyphs issue: https://github.com/Esri/esri-leaflet-vector/pull/192/commits/2d5baf7355c406b5f009db662d7b790c4480a03c
  5. Fix for that ^ glyphs issue: https://github.com/Esri/esri-leaflet-vector/pull/192/commits/5fa87e2ec10bea925e586530bbe2f15ab91282ec

@mstiglingh can you please test this out if it fixes your use case.

mstiglingh commented 1 year ago

Tested and working thanx Gavin!

mstiglingh commented 1 year ago

Just checking in on the progress of this?

gavinr-maps commented 1 year ago

@patrickarlt I have updated it to check the domain per your comment. Please review.

patrickarlt commented 11 months ago

@gavinr-maps this LGTM! Feel free to merge and release it.

gavinr-maps commented 11 months ago

This was released in v4.2.0.