Esri / esri-leaflet-vector

Display ArcGIS Online vector basemaps w/ Esri Leaflet
Apache License 2.0
56 stars 57 forks source link

add new esri openstreetmap vector basemap and bump all others to v2 #48

Closed jgravois closed 6 years ago

jgravois commented 6 years ago

while i was in here i finally figured out what was going on with the broken v2 basemaps. the problem wasn't anything in the code. there were issues in a few of the style files that trigger mapbox-gl-js validation errors.

to workaround the issue, i made copies of two and patched them manually.

World Topographic Map

Error: layers[33]: duplicate layer id "Parcel", previously used at line undefined

i fixed this one by changing the second one to "id": "ParcelFill".

World Street Map (Night)

Error: layers[74].paint.line-width.stops[2][0]: stop domain values must appear in ascending order

i fixed this one by reordering the stops to ensure the zoom levels continually increase.

"id": "Road/4WD/0",
"paint": {
    "line-width": {
        "stops": [
            // in the original, the array with 12 comes last
            [ 12, 2 ],
            [ 13, 0.85 ],
            [ 14, 1 ]
        ]
    }
}

Human Geography Detail

Error: layers[13]: duplicate layer id "Boundary line/Admin1/1", previously used at line undefined

a simplified repro case can be found below: http://jsbin.com/hulibat/edit?html,output