Esri / esri-leaflet

A lightweight set of tools for working with ArcGIS services in Leaflet. :rocket:
https://developers.arcgis.com/esri-leaflet/
Apache License 2.0
1.6k stars 798 forks source link

errors with 2.2.0 and webpack because node_modules/esri-leaflet/src/Layers is missing #1109

Closed ajrothwell closed 6 years ago

ajrothwell commented 6 years ago

Steps to reproduce the error: add esri-leaflet to package.json and build with webpack

What happens is [X]. I can't build the project any more. The errors say it is because "node_modules/esri-leaflet/src/Layers" can't be found. If you go to https://unpkg.com/esri-leaflet@2.2.0/src/, you can see there is no Layers folder anymore.

I was expecting [Y]. The project to build as it has been building for months. It still works if I force it to build with esri-leaflet 2.1.4

jgravois commented 6 years ago

ugh. this is is a bug i introduced in https://github.com/Esri/esri-leaflet/commit/cae13d321b315097d36efb0594ff0be19fc294bf

https://github.com/Esri/esri-leaflet/blob/e9a4b02f4eb963148970745f19867bc565364535/package.json#L49

should be:

"src/**/*.js"

thanks for reporting. i'll patch and release shortly.

ajrothwell commented 6 years ago

Cool, glad I could be of help

jgravois commented 6 years ago

i've released v2.2.1 with the fix. sorry for the inconvenience.