search

Esri / esri-leaflet

A lightweight set of tools for working with ArcGIS services in Leaflet. :rocket:
https://developers.arcgis.com/esri-leaflet/
Apache License 2.0
1.61k stars 799 forks source link

omit namespace when calling calcAttributionWidth from within 'Util' #850

Closed jgravois closed 8 years ago

jgravois commented 8 years ago

L.esri.Util.calcAttributionWidth(map)

https://github.com/Esri/esri-leaflet/blob/bf2e7d9bb61e0b18e74d654dd88e697139aa4974/src/Util.js#L161 https://github.com/Esri/esri-leaflet/blob/bf2e7d9bb61e0b18e74d654dd88e697139aa4974/src/Util.js#L169

jgravois commented 8 years ago

this breaks bundles downstream that want to selectively import a tree-shaken ES6 module

jgravois commented 8 years ago

thanks for volunteering to help with this one @hamhands! if you're still having trouble calling karma from the CLI next time you crack your laptop locally let me know.

hamhands commented 8 years ago

@jgravois yeah karma is still giving me hell. Ima push the changes and let travis handle it for now.