search

Esri / esri-wab-build

Package used to build ESRI Web App Builder Apps for production.
Apache License 2.0
17 stars 5 forks source link

Dojox Gauges are not Included #47

Closed gbochenek closed 5 years ago

gbochenek commented 6 years ago

Dojox Gauges are not being included into our layer files. Check for Dashboard theme before building them out?

Biboba commented 6 years ago

Hi,

I am having the same error as there: https://github.com/steveoh/grunt-esri-slurp/issues/38

That is to say:

error(311) Missing dependency. module: esri/dijit/_ObliqueRotationWidget; dependency: dojox/dgauges/CircularGauge error(311) Missing dependency. module: esri/dijit/_ObliqueRotationWidget; dependency: dojox/dgauges/CircularRangeIndicator error(311) Missing dependency. module: esri/dijit/_ObliqueRotationWidget; dependency: dojox/dgauges/LinearScaler error(311) Missing dependency. module: esri/dijit/ObliqueViewer/OVCircularScale; dependency: dojox/dgauges/CircularScale error (311) Missing dependency. module: esri/dijit/ObliqueViewer/OVCircularValueIndicator; dependency: dojox/dgauges/ScaleIndicatorBase

As suggested on the above link, I tried adding the following to the _app.config.js file but it did not solve the issue: map: { '*': { 'dojox/dgauges': 'dgauges'} }

Any idea ?

Thanks !

gbochenek commented 6 years ago

We would have to figure out a good way to make the same changes to the bower config in buildTool.js.

Biboba commented 6 years ago

OK. Will have a look at it, thanks. I don't understand though why is it bundled if it is not used in the app ?

Biboba commented 6 years ago

For reference, here are the changes that were made in esri-slurp-example project: https://github.com/tomwayson/esri-slurp-example/commit/673d98859ed76496b2c50b98693aeafaeceaf159

gavinr commented 5 years ago

@Biboba Thanks for posting that example. I had a question though: in the example, why are you including a reference to the dgauges fork ( https://github.com/dmandrioli/dgauges.git) instead of the "official" repo (https://github.com/dojo/dgauges)?

Biboba commented 5 years ago

I was just referencing the commit for information. I believe you should ask @tomwayson !

tomwayson commented 5 years ago

If the issue involves dojo, bower, and/or grunt, you should most definitely not ask me... at least, not if you want any useful information. 😄

gbochenek commented 5 years ago

@gavinr Is #63 verified to fix this issue? If so, feel free to close.