bump to jsapi 4.1, leaflet 1.0.0

Esri / geodev-hackerlabs

A place to learn how to build geo apps with the ArcGIS Platform.

Apache License 2.0

164 stars 79 forks source link

bump to jsapi 4.1, leaflet 1.0.0 #181

Closed jgravois closed 7 years ago

jgravois commented 7 years ago

also moved the 3 samples that were previously shared as blocks into the repo.

i'll fix the merge conflict here after #177 is merged.

jgravois commented 7 years ago

can i get code review and a merge for this one sometime before our next hackerlab on 10/20 please?

i tested all the samples locally and they all run just fine. (caveat: both geometry engine samples broke at 4.1 so i just left them at 4.0.)

geometryEngineAsync.geodesicBuffer(stopGeometries, miles, "miles", true).then(function(totalBuffer) {
    // promise never resolves, no error in console.

i looked at the release notes from 4.1 and the API reference and didn't find any clues there.

andygup commented 7 years ago

@jgravois sure thing. I can give it a review in the a.m.

As for the geometryEngine, maybe put together a jsbin and drop a line to the internal js alias?

jgravois commented 7 years ago

bump. (i'd really like to get _out_ of the habit of just merging my own work in this repo)

jgravois commented 7 years ago

the geometryEngineAsync thing is a bug in 4.1.