Esri / geoform-template-js

GeoForm is a configurable template for form based data editing of a Feature Service.
http://esri.github.io/geoform-template-js/
Apache License 2.0
67 stars 83 forks source link

RTL css should be after theme.css #421

Closed driskull closed 9 years ago

driskull commented 9 years ago

theme css files are messing up RTL mode. The RTL css should be loaded after theme.css so that it takes precedence.

CTDisasterManagement commented 9 years ago

@driskull

Issues #354 and #420 are related to each other. The buttons were getting overlapped with each other because "rtl.css" was not getting applied in builder mode(code was moved from "constructor" to "startup" in "main.js"). So to resolve all three issues:

Thanks!!

driskull commented 9 years ago

That sounds good. Thanks for looking into them. I thought they might be related.

On Feb 17, 2015, at 11:21 PM, CTDisasterManagement notifications@github.com<mailto:notifications@github.com> wrote:

@driskullhttps://github.com/driskull

Issues #354https://github.com/Esri/geoform-template-js/issues/354 and #420https://github.com/Esri/geoform-template-js/issues/420 are related to each other. The buttons were getting overlapped with each other because "rtl.css" was not getting applied in builder mode(code was moved from "constructor" to "startup" in "main.js"). So to resolve all three issues:

— Reply to this email directly or view it on GitHubhttps://github.com/Esri/geoform-template-js/issues/421#issuecomment-74823077.