search

Esri / geomessage-simulator-qt

The GeoMessage Simulator provides UDP messaging for applications that are part of the ArcGIS for the Military solution.
Apache License 2.0
17 stars 22 forks source link

Retiring Vehicle Commander Qt #17

Closed garysheppardjr closed 9 years ago

garysheppardjr commented 9 years ago

Retiring Vehicle Commander Qt but keeping Message Simulator Qt.

Fixes #16

garysheppardjr commented 9 years ago

@csmoore, can you please review and merge?

csmoore commented 9 years ago

I'm going to try to build/run this now as a final sanity check, but just curious does this test driver still work? https://github.com/garys-esri/message-simulator-qt/tree/master/source/test/SampleUnitTest (looks like it would need to have .pro path updated to ArcGISQtMessageSimulator at a minimum)

csmoore commented 9 years ago

Maybe we could now also rename the repo/app to geomessage-simulator-qt for additional clarity. Since the geomessage term is being used elsewhere across the stack.

csmoore commented 9 years ago

OK I finished having a look - only recommendations to complete before merging are

  1. Updating or Removing test project: https://github.com/garys-esri/message-simulator-qt/tree/master/source/test/SampleUnitTest
  2. A few minor doc things/enhancement noted

Just let me know when you want me to have a re-look/merge.

I'll add issues now for the 2 more involved enhancements (add stand-alone deployment download & rename the repo)

garysheppardjr commented 9 years ago

Removed test code in 673997b60d1e345d7511186a13429a46d8584fdc.

garysheppardjr commented 9 years ago

I’d love to rename the repo but it seems I’ve lost admin access here as well as in vehicle-commander-java, both of which I renamed yesterday. Weird.

csmoore commented 9 years ago

I noticed/had that same issue - I'll need to check into...

@ACueva - do you know if this is related to the recent "solutions" vs. "defense" teams stuff (which I'm not even sure what is happening there) or is there something else going on?

csmoore commented 9 years ago

This looks really good.

We can do the rename after the merge and the permissions issue get sorted out.

garysheppardjr commented 9 years ago

Repo renamed in da414ec62fa7be21700535aac071e426d070acc8