Esri / geoservices-ruby

Ruby library for interacting with Geoservices
Apache License 2.0
12 stars 17 forks source link

Geoservice::Base is using `throw` for errors instead of `raise` #9

Open corwinstephen opened 1 year ago

corwinstephen commented 1 year ago
  1. This isn't how errors are handled in Ruby
  2. The parameter being passed to throw is unpredictable, making it impossible to catch even if we wanted to.

At minimum, the two instances of throw in this file should be changed to raise