search

Esri / i3s-spec

This repository hosts the specification for Scene Layers which are containers for arbitrarily large amounts of geographic data. The delivery and persistence model for Scene Layers, referred to as Indexed 3d Scene Layer (I3S) and Scene Layer Package (SLPK) respectively, are specified.
Other
319 stars 85 forks source link

Parameter Definition Issues #20

Closed intckarl closed 5 years ago

intckarl commented 5 years ago

I found maxScreenThresholdSQ under lodSelection, with a similar parameter named maxScreenThreshold without SQ.

But in your doc, there is only description for maxScreenThreshold, so I'm wondering what does SQ means and how does it effect lodSelection

Thank you

jfoster126 commented 5 years ago

Hi @intckarl ,

The maxScreenThresholdSQ values are calculated 

maxScreenThresholdSQ = PI * 0.25 * maxScreenThreshold * maxScreenThreshold

maxScreenThresholdSQ is used to help with better view frustum culling and increases benefits from the non-isotropic screen projected size.

I will add this to the spec as well, thank you food your feedback.

intckarl commented 5 years ago

@jfoster126 Thank you for reply!
One more thing, there are still some more unclear things in the I3S document. Some have totally different name and where to use, but with the same description. Also there are parameters just say "Definition missing!" (lodModel in store.cmn.md) And there are parameters without any description at all... Would you please fix these? I really want to get a real study in this. Thank you.

jfoster126 commented 5 years ago

@intckarl We are actively working on the spec and hope to release an updated version this summer.

jfoster126 commented 5 years ago

Hi @intckarl ,

We pushed an update to the spec today that includes fixes for these issues. Please open a new issue if you find anything else or have more questions. Thanks.