Esri / i3s-spec

This repository hosts the specification for Scene Layers which are containers for arbitrarily large amounts of geographic data. The delivery and persistence model for Scene Layers, referred to as Indexed 3d Scene Layer (I3S) and Scene Layer Package (SLPK) respectively, are specified.
Other
318 stars 85 forks source link

OBB description confusing #87

Closed abellgithub closed 4 years ago

abellgithub commented 4 years ago

https://github.com/Esri/i3s-spec/blob/master/docs/1.7/obb.cmn.md

In the above, the halfSize talks about the units of the center, rather than the halfSize. It also seems at odds with the example at the bottom.

The example says that it's WGS84 (by which I assume you mean latitude/longitude/height in meters based on your description of center), but there is no -105 latitude. If I take it to be longitude/latitude/height, it makes sense, but then halfSize makes no sense, because surely the X and Y aren't in degrees.

Then you say something about the quaternion being ECEF, which seems strange, as that's a different system from the original one. Is one expected to transform the center/halfSize to ECEF and then apply the quat?

Some examples with math would be very helpful.

rvargasESRI commented 4 years ago

Hello @abellgithub We have made changes to the OBB documentation. Thanks for bringing this to our attention.