Open Dash83UPV opened 6 years ago
Not sure what you are using to test, but if it is the demo app in this repo, then probably just a bug - they look like valid (2525C) symbols. I get same (bad) results.
Hello csmoore, then how can I proceed? I do not know if I will be able to debug the code.
I have found that in Librarian.cs the method internal SymbolSetLegacySymbol LegacySymbol(SymbolSet symbolSet, string legacySIDC)
returns obj null, because it cannot find anything that matches the legacySIDC
@Dash83UPV - I probably would not be able to debug either given the complexity of the datamodel/code - I believe this repo was primarily designed/tested with 2525D - but there are other tested repos/libraries you could use that do fully support 2525C.
Chris: I haven't been following this discussion. What's the problem?
Bill McGrane Chair, SSMC DISA BDE4 Standards Management Branch Comm: 301-225-7383 DSN: 312-375-7383
-----Original Message----- From: Chris Moore [mailto:notifications@github.com] Sent: Friday, February 9, 2018 7:26 AM To: Esri/joint-military-symbology-xml joint-military-symbology-xml@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [Non-DoD Source] Re: [Esri/joint-military-symbology-xml] Infraestructure Symbols not working (#483)
All active links contained in this email were disabled. Please verify the identity of the sender, and confirm the authenticity of all links contained within the message prior to copying and pasting the address to a Web browser.
@Dash83UPV < Caution-https://github.com/dash83upv > - I probably would not be able to debug either given the complexity of the datamodel/code - I believe this repo was primarily designed/tested with 2525D - but there are other tested repos/libraries you could use that do fully support 2525C.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < Caution-https://github.com/Esri/joint-military-symbology-xml/issues/483#issuecomment-364420246 > , or mute the thread < Caution-https://github.com/notifications/unsubscribe-auth/AI5Tbe5iLc4pUV1SZzjNDy8eVBfganu-ks5tTDlFgaJpZM4R-rw6 > . <Caution-https://github.com/notifications/beacon/AI5TbeXSG4K_oJMhgHREt07vds37q4fHks5tTDlFgaJpZM4R-rw6.gif>
@wmcgrane - its just a bug in the test app (screenshot above) / API converting 2525D SIDCs/symbols to 2525C. We used the mapping table provided so we know the data generally works for this - though we did have to make numerous manual (minor) changes to complete this mapping, but nothing in the Emergency Set.
@Dash83UPV this is a 2525D repository, with some legacy mapping back to 2525C, but it's incomplete (as you found). Look for this code, and see if that's what you want: 20112200.
That said, any updates you want to provide to this repository are welcome, the XML is here: https://github.com/Esri/joint-military-symbology-xml/blob/dev/instance/Land_Installation.xml
As @csmoore said, depending on what you're trying to do, there are other repositories out there. So, you want to use 2525C emergency symbols in what platform? ArcGIS?
Joe: A concern is the comment that Esri has found some incomplete mappings. Do you know which ones and how many? We'd like to be able to update and fix our spreadsheet.
Bill McGrane Chair, SSMC DISA BDE4 Standards Management Branch Comm: 301-225-7383 DSN: 312-375-7383
-----Original Message----- From: Joe Bayles [mailto:notifications@github.com] Sent: Friday, February 9, 2018 11:58 AM To: Esri/joint-military-symbology-xml joint-military-symbology-xml@noreply.github.com Cc: Mcgrane, William M (Bill) CIV DISA BD (US) william.m.mcgrane.civ@mail.mil; Mention mention@noreply.github.com Subject: [Non-DoD Source] Re: [Esri/joint-military-symbology-xml] Infraestructure Symbols not working (#483)
All active links contained in this email were disabled. Please verify the identity of the sender, and confirm the authenticity of all links contained within the message prior to copying and pasting the address to a Web browser.
@Dash83UPV < Caution-https://github.com/dash83upv > this is a 2525D repository, with some legacy mapping back to 2525C, but it's incomplete (as you found). Look for this code, and see if that's what you want: 20112200.
That said, any updates you want to provide to this repository are welcome, the XML is here: Caution-https://github.com/Esri/joint-military-symbology-xml/blob/dev/instance/Land_Installation.xml < Caution-https://github.com/Esri/joint-military-symbology-xml/blob/dev/instance/Land_Installation.xml >
As @csmoore < Caution-https://github.com/csmoore > said, depending on what you're trying to do, there are other repositories out there. So, you want to use 2525C emergency symbols in what platform? ArcGIS?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < Caution-https://github.com/Esri/joint-military-symbology-xml/issues/483#issuecomment-364492704 > , or mute the thread < Caution-https://github.com/notifications/unsubscribe-auth/AI5TbUXFrjX13mwkuan6Z3lXXkV0F5Gzks5tTHk0gaJpZM4R-rw6 > . <Caution-https://github.com/notifications/beacon/AI5TbQN6wWnI518JKYw5roLG2gUqXWsSks5tTHk0gaJpZM4R-rw6.gif>
Hello JMSML community
First and foremost, this is an amazing library and I will like to thank you all for your hard work. :)
I found some issues with symbols that were not available, but there were one less that 0,5%. Unfortunately, I started working with emergencies and I have encounter many symbols that are not available, mostly all the emergency - infrastructure, EFF-A---------- EFF-DB--------- etc. or the emergency - operations - installations. EFO-DC--------- EFO-DDC-------- for example.
Perhaps I'm doing something wrong. Could you gladly help me or explain how can I add them to the library if I have the SVG file pieces?
Thanks and best regards.