Esri / local-government-desktop-addins

A series of ArcGIS Desktop Add-ins used in the ArcGIS for Local Government editing maps.
Apache License 2.0
61 stars 56 forks source link

BUG-000104801 Attribute Assistant Value Method Field_Trigger is not working for manual or geometry changes. #238

Closed MikeMillerGIS closed 2 years ago

MikeMillerGIS commented 7 years ago
Salesforce ID: BUG-000104801
Salesforce Submitter: Barbara Sieg
Salesforce Submit Date: 4/28/2017 8:30 AM
Salesforce Bug Type: Failure/Error
Salesforce Severity: Medium
Repro Data: \\esri.com\sf_filestore\PRD\Attachments\Defects\BUG-000104801
Work Around: Use the Expression value method instead. Set the FieldName to the field to be updated, not the field to monitor. The ValueInfo can be similar to this: IIF ([] = , , [])
Product: ArcGIS for Local Government
Functional Category: ArcGIS for Local Government
Client Platform: (n/a)
Version Found: 10.5
Planned Version Fixed: (n/a)
Comment: The current code for field trigger will only run if the field is changed. We can bypass this check so the rule runs for On Manual as well as the other rules.
MikeMillerGIS commented 7 years ago
previnWong commented 6 years ago

@MikeMillerGIS can you check this scenario. doesn't work in 10.6 or 10.2

Start an edit session and enter "Drunkenness" in the Problem field. In the Dynamic Value table, change On_Manual to 0 and On_ChangeGeo to 1. Select the first feature in Incidents and move the feature. The Problem2 field is not updated. (not working) Click the "Run Change Geometry Rules" button; nothing happens. (works)

MikeMillerGIS commented 6 years ago

yes, it probably should. What the code is doing is checking if the row changed to process the rule. It bypasses this check if you click any of the tools on the AA, it is not checking if you did actually changed the geo. I can make that fix, but not worth a rebuild,

MikeMillerGIS commented 6 years ago

I think we should move this back to in Dev and pick up next time

MikeMillerGIS commented 6 years ago

@previnWong @clareprice based on previns findings, moving out of installed and setting to the next deliverable.

MikeMillerGIS commented 6 years ago

fix: if (pRowCh.get_ValueChanged(intFldIdxs[0]) == true || mode == "ON_MANUAL" || AAState.triggerByTools == AAState.TriggerByToolsOptions.Manual || AAState.triggerByTools == AAState.TriggerByToolsOptions.Geo || AAState.triggerByTools == AAState.TriggerByToolsOptions.Change || AAState.triggerByTools == AAState.TriggerByToolsOptions.Create) {

Add checking for On_Change_Geo to this block

LindsayThomas commented 2 years ago

Closing to match backend support app