search

Esri / map-tools-template

Configurable application template that enables you to display an ArcGIS web map using a variety of tools.
Apache License 2.0
23 stars 32 forks source link

Enhance the main startup function and prevent startup error #9

Closed lscharen closed 9 years ago

lscharen commented 9 years ago

I have made one fix and one enhancement to the main.js file

Several lines that contained trailing whitespace were automatically cleaned up by a code linter. I can revert the whitespace if this PR is otherwise acceptable.

kellyhutchins commented 9 years ago

@lscharen thanks for the pull request. I'll fix the invalid css selector.

For the deferred issue all the templates are built on some boilerplate code that sets up the basic structure. In this boilerplate we have logic that calls a function (Hello World) when the map has been created. @driskull any thoughts on returning the createMap deferred in startup?

https://github.com/Esri/application-boilerplate-js/blob/development/application_boilerplate/js/main.js

driskull commented 9 years ago

yeah we could do that.

kellyhutchins commented 9 years ago

@driskull ok i'll add an issue to the app boilerplate repo. @lscharen once the boilerplate code is updated we'll update the templates to reflect that change.

Boilerplate Issue: https://github.com/Esri/application-boilerplate-js/issues/60