Closed zinfin closed 7 years ago
@doneill I've submitted fixes for this PR, ready for your review.
@doneill Shall I go ahead and merge with master?
@zinfin Updates look good, yes I think we can merge to master and consider creating issues for the outstanding comments.
@doneill The mapbook app is just about feature complete. The missing functionality is the auto update of the mapbook, but we're waiting on a discussion before implementing that functionality.
I've added a number of TODOs to the app where you'll find specific questions that I'd like your feedback on. In addition, since this app uses Dagger2, I'd really appreciate your comments on 1) if I'm using Dagger correctly in the app, and 2) any suggestions on where else in the app Dagger should be used.
Please try running the Robotium tests.