search

Esri / mapbook-android

App to replace paper maps for field work
Apache License 2.0
12 stars 13 forks source link

Push development branch to master #2

Closed zinfin closed 7 years ago

zinfin commented 7 years ago

@doneill The mapbook app is just about feature complete. The missing functionality is the auto update of the mapbook, but we're waiting on a discussion before implementing that functionality.

I've added a number of TODOs to the app where you'll find specific questions that I'd like your feedback on. In addition, since this app uses Dagger2, I'd really appreciate your comments on 1) if I'm using Dagger correctly in the app, and 2) any suggestions on where else in the app Dagger should be used.

Please try running the Robotium tests.

zinfin commented 7 years ago

@doneill I've submitted fixes for this PR, ready for your review.

zinfin commented 7 years ago

@doneill Shall I go ahead and merge with master?

doneill commented 7 years ago

@zinfin Updates look good, yes I think we can merge to master and consider creating issues for the outstanding comments.